Skip to content

Conversation

@vanzin
Copy link
Contributor

@vanzin vanzin commented Jul 22, 2015

Doing this may cause weird errors when tests are run on maven, depending
on the flags used. Instead, expose the needed functionality through methods
that do not expose shaded classes.

Doing this may cause weird errors when tests are run on maven, depending
on the flags used. Instead, expose the needed functionality through methods
that do not expose shaded classes.
@vanzin
Copy link
Contributor Author

vanzin commented Jul 22, 2015

/cc @tdas

@SparkQA
Copy link

SparkQA commented Jul 22, 2015

Test build #38113 has finished for PR 7601 at commit 4f64a16.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • case class CreateArray(children: Seq[Expression]) extends Expression
    • case class CreateStruct(children: Seq[Expression]) extends Expression
    • case class CreateNamedStruct(children: Seq[Expression]) extends Expression

@vanzin
Copy link
Contributor Author

vanzin commented Jul 23, 2015

Jenkins retest this please.

@tdas
Copy link
Contributor

tdas commented Jul 23, 2015

cc @zsxwing you have a better idea of this code.

@SparkQA
Copy link

SparkQA commented Jul 23, 2015

Test build #38147 has finished for PR 7601 at commit 4f64a16.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jul 23, 2015

Test build #69 timed out for PR 7601 at commit 4f64a16 after a configured wait of 175m.

@zsxwing
Copy link
Member

zsxwing commented Jul 23, 2015

retest this please.

@zsxwing
Copy link
Member

zsxwing commented Jul 23, 2015

LGTM

@SparkQA
Copy link

SparkQA commented Jul 23, 2015

Test build #83 has finished for PR 7601 at commit 4f64a16.

  • This patch fails Scala style tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jul 23, 2015

Test build #38245 has finished for PR 7601 at commit 4f64a16.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@vanzin
Copy link
Contributor Author

vanzin commented Jul 23, 2015

Lots of test flakiness lately.

@vanzin
Copy link
Contributor Author

vanzin commented Jul 23, 2015

retest this please

@SparkQA
Copy link

SparkQA commented Jul 24, 2015

Test build #38278 has finished for PR 7601 at commit 4f64a16.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jul 24, 2015

Test build #84 has finished for PR 7601 at commit 4f64a16.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@vanzin
Copy link
Contributor Author

vanzin commented Jul 24, 2015

Merged to master.

@asfgit asfgit closed this in 8399ba1 Jul 24, 2015
@vanzin vanzin deleted the SPARK-9261 branch July 30, 2015 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants