[SPARK-9225] [MLlib] LDASuite needs unit tests for empty documents

[rotationsymmetry]

Add unit tests for running LDA with empty documents.
Both EMLDAOptimizer and OnlineLDAOptimizer are tested.

@feynmanliang

[yu-iskw]

@rotationsymmetry Great work! We could also implement those two tests in one test suite with for-loop of the optimizers instead. Since both of them are almost same and there is a difference about the optimizers.

@feynmanliang What do you think?

[feynmanliang]

LGTM pending tests, we'll need @jkbradley to trigger the Jenkins build.

I would actually prefer that the two be in separate tests so it's easy to identify which optimizer is failing by just looking at which test is failing. I agree there is quite a bit of DRYing to do in LDASuite, but that can be addressed in some follow up PRs.

[yu-iskw]

@feynmanliang I got it. Thanks.

[rotationsymmetry]

@yu-iskw @feynmanliang Thanks for your review!

@jkbradley Will you please trigger the Jenkins build?

[yu-iskw]

Jenkins, test this please.

[mengxr]

ok to test

[rotationsymmetry]

@mengxr Thank you for OK to test.

I checked the Jerkins log. The failure is caused by git unable to fetch the repo. Anything on my end to fix it?

cc @feynmanliang @yu-iskw

From Jenkins log:

GitHub pull request #7620 of commit ad55665f083025074bf3f350a1a66baab9d4a4be automatically merged.
[EnvInject] - Loading node environment variables.
Building remotely on amp-jenkins-worker-07 (centos) in workspace /home/jenkins/workspace/SparkPullRequestBuilder
 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url https://github.com/apache/spark.git # timeout=10
Fetching upstream changes from https://github.com/apache/spark.git
 > git --version # timeout=10
 > git fetch --tags --progress https://github.com/apache/spark.git +refs/pull/7620/*:refs/remotes/origin/pr/7620/* # timeout=15
ERROR: Timeout after 15 minutes
ERROR: Error fetching remote repo 'origin'
hudson.plugins.git.GitException: Failed to fetch from https://github.com/apache/spark.git
    at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:735)
    at hudson.plugins.git.GitSCM.retrieveChanges(GitSCM.java:983)
    at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1016)
    at hudson.scm.SCM.checkout(SCM.java:485)
    at hudson.model.AbstractProject.checkout(AbstractProject.java:1282)
    at hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:610)
    at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86)
    at hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:532)
    at hudson.model.Run.execute(Run.java:1741)
    at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
    at hudson.model.ResourceController.execute(ResourceController.java:98)
    at hudson.model.Executor.run(Executor.java:381)
Caused by: hudson.plugins.git.GitException: Command "git fetch --tags --progress https://github.com/apache/spark.git +refs/pull/7620/*:refs/remotes/origin/pr/7620/*" returned status code 143:
stdout: 
stderr: error: RPC failed; result=18, HTTP code = 200

    at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:1591)
    at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandWithCredentials(CliGitAPIImpl.java:1379)
    at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.access$300(CliGitAPIImpl.java:86)
    at org.jenkinsci.plugins.gitclient.CliGitAPIImpl$1.execute(CliGitAPIImpl.java:324)
    at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$1.call(RemoteGitImpl.java:152)
    at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$1.call(RemoteGitImpl.java:145)
    at hudson.remoting.UserRequest.perform(UserRequest.java:121)
    at hudson.remoting.UserRequest.perform(UserRequest.java:49)
    at hudson.remoting.Request$2.run(Request.java:325)
    at hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:68)
    at java.util.concurrent.FutureTask.run(FutureTask.java:262)
    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
    at java.lang.Thread.run(Thread.java:745)
    at ......remote call to amp-jenkins-worker-07(Native Method)
    at hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1361)
    at hudson.remoting.UserResponse.retrieve(UserRequest.java:221)
    at hudson.remoting.Channel.call(Channel.java:753)
    at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.execute(RemoteGitImpl.java:145)
    at sun.reflect.GeneratedMethodAccessor230.invoke(Unknown Source)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke(Method.java:606)
    at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.invoke(RemoteGitImpl.java:131)
    at com.sun.proxy.$Proxy54.execute(Unknown Source)
    at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:733)
    ... 11 more
ERROR: Error fetching remote repo 'origin'
Archiving artifacts
Recording test results
ERROR: Publisher 'Publish JUnit test result report' failed: Test reports were found but none of them are new. Did tests run? 
For example, /home/jenkins/workspace/SparkPullRequestBuilder/bagel/target/test-reports/org.apache.spark.bagel.BagelSuite.xml is 2 hr 19 min old

Finished: FAILURE

[mengxr]

test this please

[SparkQA]

Test build #38676 has finished for PR 7620 at commit ad55665.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[mengxr]

minor: test("EMLDAOptimizer with empty docs")

[rotationsymmetry]

@mengxr Thanks a lot for your comments! It is very helpful. I have incorporated them in the commit.

[SparkQA]

Test build #38793 has finished for PR 7620 at commit f9432e8.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[mengxr]

minor: it is not necessary to have extra blank lines in Spark code base

[SparkQA]

Test build #39003 has finished for PR 7620 at commit 3ed7c88.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[mengxr]

LGTM. Merged into master. Thanks!