Skip to content

Conversation

@yu-iskw
Copy link
Contributor

@yu-iskw yu-iskw commented Jul 28, 2015

No description provided.

@SparkQA
Copy link

SparkQA commented Jul 28, 2015

Test build #38620 has finished for PR 7708 at commit 35f4430.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@vanzin
Copy link
Contributor

vanzin commented Jul 28, 2015

Hi,

Since this is not fixing a build break, "hotfix" doesn't really apply. Otherwise, looks straight-forward enough.

@srowen
Copy link
Member

srowen commented Jul 28, 2015

Agree, this is not a fix. The modern way to write code javadoc is ...

{@code
val foo = ...
}

... but for consistency with other javadoc this is good enough.

@yu-iskw
Copy link
Contributor Author

yu-iskw commented Jul 28, 2015

@srowen how about changing all the <pre> to {@code...}?

@srowen
Copy link
Member

srowen commented Jul 28, 2015

Hm, I do see many more uses of {@code } in the project than <pre> for this purpose, which is good. It would be reasonable to fix, at least, all the Java examples in one go here. Or, even fix all 14 instances I see in the code at once, everywhere. If so, make a JIRA please.

@yu-iskw
Copy link
Contributor Author

yu-iskw commented Jul 28, 2015

Alright. I'll create a JIRA to change all <pre> to {@code...}. I'll send another PR later. Thanks!

@yu-iskw yu-iskw closed this Jul 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants