Skip to content

[SPARK-9425] [SQL] support DecimalType in UnsafeRow #7758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
davies wants to merge 6 commits into from
Closed

[SPARK-9425] [SQL] support DecimalType in UnsafeRow #7758

davies wants to merge 6 commits into from

Conversation

@davies
Copy link
Contributor

@davies davies commented Jul 29, 2015

This PR brings the support of DecimalType in UnsafeRow, for precision <= 18, it's settable, otherwise it's not settable.

@SparkQA
Copy link

SparkQA commented Jul 29, 2015

Test build #38893 has finished for PR 7758 at commit 888dd9b.

  • This patch fails to build.
  • This patch merges cleanly.
  • This patch adds no public classes.

Merge branch 'master' of github.com:apache/spark into unsafe_decimal
99d3151 
Conflicts:
	sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/UnsafeRow.java
	sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateUnsafeProjection.scala
@SparkQA
Copy link

SparkQA commented Jul 29, 2015

Test build #38903 has finished for PR 7758 at commit 99d3151.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • public static class CompactDecimalWriter
    • public static class DecimalWriter

@davies davies changed the title [SPARK-9425] [SQL] [WIP] support DecimalType in UnsafeRow [SPARK-9425] [SQL] support DecimalType in UnsafeRow Jul 30, 2015
@SparkQA
Copy link

SparkQA commented Jul 30, 2015

Test build #38930 has finished for PR 7758 at commit 6c062d9.

  • This patch fails Scala style tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jul 30, 2015

Test build #1229 has finished for PR 7758 at commit 99d3151.

  • This patch fails Scala style tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jul 30, 2015

Test build #38934 has finished for PR 7758 at commit 76d6fa4.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • public static class CompactDecimalWriter
    • public static class DecimalWriter

@SparkQA
Copy link

SparkQA commented Jul 30, 2015

Test build #1230 has finished for PR 7758 at commit 76d6fa4.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jul 30, 2015

Test build #39009 has finished for PR 7758 at commit 7c2e77a.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • public static class CompactDecimalWriter
    • public static class DecimalWriter

@SparkQA
Copy link

SparkQA commented Jul 30, 2015

Test build #39088 has finished for PR 7758 at commit 341bb97.

  • This patch fails to build.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • public static class CompactDecimalWriter
    • public static class DecimalWriter

Merge branch 'master' of github.com:apache/spark into unsafe_decimal
536314c 
Conflicts:
	sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
@SparkQA
Copy link

SparkQA commented Jul 30, 2015

Test build #39093 has finished for PR 7758 at commit 536314c.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • public static class CompactDecimalWriter
    • public static class DecimalWriter
    • case class UnixTimestamp(timeExp: Expression, format: Expression)
    • case class FromUnixTime(sec: Expression, format: Expression)
    • abstract class ArrayData extends SpecializedGetters with Serializable
    • class GenericArrayData(array: Array[Any]) extends ArrayData

@davies
Copy link
Contributor Author

davies commented Jul 30, 2015

ping @rxin

rxin
rxin reviewed Jul 30, 2015
View reviewed changes
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/UnsafeRow.java Outdated
Copy link
Contributor

@rxin rxin Jul 30, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should go before the isNullAt check

@rxin
Copy link
Contributor

rxin commented Jul 30, 2015

LGTM

@SparkQA
Copy link

SparkQA commented Jul 30, 2015

Test build #39114 has finished for PR 7758 at commit 478b1ba.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • public static class CompactDecimalWriter
    • public static class DecimalWriter

@rxin
Copy link
Contributor

rxin commented Jul 31, 2015

Merging this in since the test failure is unrelated.

@asfgit asfgit closed this in 0b1a464 Jul 31, 2015
@SparkQA
Copy link

SparkQA commented Jul 31, 2015

Test build #1247 has finished for PR 7758 at commit 478b1ba.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@davies @SparkQA @rxin