[SPARK-9553][SQL] remove the no-longer-necessary createCode and createStructCode, and replace the usage

[cloud-fan]

No description provided.

[cloud-fan]

cc @rxin

[rxin]

LGTM

[SparkQA]

Test build #39526 has finished for PR 7890 at commit af68d20.

• This patch fails to build.
• This patch merges cleanly.
• This patch adds the following public classes (experimental):
  • class NaiveBayes(JavaEstimator, HasFeaturesCol, HasLabelCol, HasPredictionCol, HasProbabilityCol,
  • public class UnsafeArrayData extends ArrayData
  • public class UnsafeMapData extends MapData
  • public class UnsafeReaders
  • public static class ArrayWriter
  • public static class MapWriter
  • public class UnsafeWriters
  • public static class DecimalWriter
  • public static class UTF8StringWriter
  • public static class BinaryWriter
  • public static class StructWriter
  • public static class IntervalWriter
  • public static class ArrayWriter
  • public static class MapWriter
  • case class FromUnsafe(child: Expression) extends UnaryExpression
  • class RowOrdering(ordering: Seq[SortOrder]) extends Ordering[InternalRow]
  • case class AtLeastNNulls(n: Int, children: Seq[Expression]) extends Predicate
  • case class AtLeastNNonNullNans(n: Int, children: Seq[Expression]) extends Predicate
  • class DefaultOptimizer extends Optimizer
  • case class PartitioningCollection(partitionings: Seq[Partitioning])
  • case class FilterNullsInJoinKey(

[cloud-fan]

it's not minor anymore as we need ceateCode some place else...
I have created a JIRA for it.

[SparkQA]

Test build #39537 has finished for PR 7890 at commit d561e42.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[rxin]

LGTM

[SparkQA]

Test build #39545 has finished for PR 7890 at commit b0cbe2e.

• This patch fails Scala style tests.
• This patch merges cleanly.
• This patch adds no public classes.

[SparkQA]

Test build #39717 has finished for PR 7890 at commit c3b1be3.

• This patch fails Spark unit tests.
• This patch merges cleanly.
• This patch adds no public classes.

[SparkQA]

Test build #1330 has finished for PR 7890 at commit c3b1be3.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[rxin]

I've merged this. Thanks.

[rxin]

This hasn't been merged yet because there are some problems with asf git.

https://issues.apache.org/jira/browse/INFRA-10079

[rxin]

Merged now.