Skip to content

[SPARK-9609][MLlib] Fix spelling of Strategy.defaultStrategy #7941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
feynmanliang wants to merge 2 commits into from
Closed

[SPARK-9609][MLlib] Fix spelling of Strategy.defaultStrategy #7941

feynmanliang wants to merge 2 commits into from

Conversation

@feynmanliang
Copy link
Contributor

@feynmanliang feynmanliang commented Aug 4, 2015

srowen
srowen reviewed Aug 4, 2015
View reviewed changes
mllib/src/main/scala/org/apache/spark/mllib/tree/configuration/Strategy.scala
Copy link
Member

@srowen srowen Aug 4, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's OK to just change this API method because it's experimental? Instead of doing all that deprecation and stuff? FWIW I would agree with that.

Copy link
Contributor Author

@feynmanliang feynmanliang Aug 4, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, this has been around since 1.2 so it might break backwards compatibility. Let's keep the discussion going

Copy link
Member

@jkbradley jkbradley Aug 4, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I'd prefer we keep a deprecated version so we don't break user code. It's just one tiny method.

@SparkQA
Copy link

SparkQA commented Aug 4, 2015

Test build #39744 has finished for PR 7941 at commit aa090a8.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@jkbradley
Copy link
Member

jkbradley commented Aug 4, 2015

@feynmanliang Can you please add the "mllib" tag to the PR title?

@feynmanliang feynmanliang changed the title [SPARK-9609] Fix spelling of Strategy.defaultStrategy [SPARK-9609][MLlib] Fix spelling of Strategy.defaultStrategy Aug 4, 2015
@jkbradley
Copy link
Member

jkbradley commented Aug 4, 2015

Thanks. LGTM pending tests

@SparkQA
Copy link

SparkQA commented Aug 4, 2015

Test build #39775 has finished for PR 7941 at commit d2aafb1.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@jkbradley
Copy link
Member

jkbradley commented Aug 5, 2015

Merging with master and branch-1.5
Thanks!

asfgit pushed a commit that referenced this pull request Aug 5, 2015
@jkbradley
[SPARK-9609] [MLLIB] Fix spelling of Strategy.defaultStrategy
3350975 
jkbradley

Author: Feynman Liang <fliang@databricks.com>

Closes #7941 from feynmanliang/SPARK-9609-stategy-spelling and squashes the following commits:

d2aafb1 [Feynman Liang] Add deprecated backwards compatibility
aa090a8 [Feynman Liang] Fix spelling

(cherry picked from commit 629e26f)
Signed-off-by: Joseph K. Bradley <joseph@databricks.com>
@asfgit asfgit closed this in 629e26f Aug 5, 2015
@feynmanliang feynmanliang deleted the SPARK-9609-stategy-spelling branch August 17, 2015 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@feynmanliang @SparkQA @jkbradley @srowen