Skip to content

[SPARK-9832] [SQL] add a thread-safe lookup for BytesToBytseMap#8151

Closed
davies wants to merge 3 commits intoapache:masterfrom
davies:safeLookup
Closed

[SPARK-9832] [SQL] add a thread-safe lookup for BytesToBytseMap#8151
davies wants to merge 3 commits intoapache:masterfrom
davies:safeLookup

Conversation

@davies
Copy link
Contributor

@davies davies commented Aug 12, 2015

This patch add a thread-safe lookup for BytesToBytseMap, and use that in broadcasted HashedRelation.

@davies
Copy link
Contributor Author

davies commented Aug 12, 2015

cc @JoshRosen

@SparkQA
Copy link

SparkQA commented Aug 13, 2015

Test build #1516 has finished for PR 8151 at commit fb64d6a.

  • This patch fails to build.
  • This patch merges cleanly.
  • This patch adds no public classes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't return the loc; it's void.

@JoshRosen
Copy link
Contributor

LGTM.

@SparkQA
Copy link

SparkQA commented Aug 13, 2015

Test build #40698 timed out for PR 8151 at commit a7604e7 after a configured wait of 175m.

@SparkQA
Copy link

SparkQA commented Aug 13, 2015

Test build #40701 timed out for PR 8151 at commit 8daa2cd after a configured wait of 175m.

@rxin
Copy link
Contributor

rxin commented Aug 13, 2015

I'm going to merge thsi.

asfgit pushed a commit that referenced this pull request Aug 13, 2015
This patch add a thread-safe lookup for BytesToBytseMap, and use that in broadcasted HashedRelation.

Author: Davies Liu <davies@databricks.com>

Closes #8151 from davies/safeLookup.

(cherry picked from commit a8ab263)
Signed-off-by: Reynold Xin <rxin@databricks.com>
@asfgit asfgit closed this in a8ab263 Aug 13, 2015
@SparkQA
Copy link

SparkQA commented Aug 13, 2015

Test build #1536 has finished for PR 8151 at commit 8daa2cd.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

CodingCat pushed a commit to CodingCat/spark that referenced this pull request Aug 17, 2015
This patch add a thread-safe lookup for BytesToBytseMap, and use that in broadcasted HashedRelation.

Author: Davies Liu <davies@databricks.com>

Closes apache#8151 from davies/safeLookup.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants