[SPARK-10012][ML] Missing test case for Params#arrayLengthGt #8223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #40981 has finished for PR 8223 at commit
|
Member
|
LGTM, but I'll wait to merge with master until after the RC is cut |
Contributor
Author
|
@jkbradley OK, thanks! |
Member
|
@jkbradley do we need to wait for something here? things can go into |
Member
|
No, just trying not merge stuff which isn't critical, but sure, I'll merge it with master and branch-1.5 |
asfgit
pushed a commit
that referenced
this pull request
Aug 18, 2015
Currently there is no test case for `Params#arrayLengthGt`. Author: lewuathe <lewuathe@me.com> Closes #8223 from Lewuathe/SPARK-10012. (cherry picked from commit c635a16) Signed-off-by: Joseph K. Bradley <joseph@databricks.com>
Member
|
I like the caution on 1.5; master should be safe in any event. It's my impression that in the QA period new tests (which pass) are pretty freely mergeable. Maybe I should send around an email about the consensus on that to make sure we're operating similarly. +1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there is no test case for
Params#arrayLengthGt.