Skip to content

[SPARK-9895] User Guide for RFormula Feature Transformer #8293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ericl wants to merge 7 commits into from
Closed

[SPARK-9895] User Guide for RFormula Feature Transformer #8293

ericl wants to merge 7 commits into from

Conversation

@ericl
Copy link
Contributor

@ericl ericl commented Aug 19, 2015

mengxr
mengxr reviewed Aug 19, 2015
View reviewed changes
docs/ml-features.md Outdated
Copy link
Contributor

@mengxr mengxr Aug 19, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Insert an empty line to make it a section title. You can run SKIP_API=1 jekyll build under spark/docs/ to build the user guide.

Copy link
Contributor Author

@ericl ericl Aug 19, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added (though it didn't seem to make a difference).

mengxr
mengxr reviewed Aug 19, 2015
View reviewed changes
docs/ml-features.md Outdated
Copy link
Contributor

@mengxr mengxr Aug 19, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment below about the expected output. OneHotEncoder removes the last factor level.

@ericl
Copy link
Contributor Author

ericl commented Aug 19, 2015

Fixed and verified.

ericl added 2 commits August 19, 2015 14:16
@SparkQA
Copy link

SparkQA commented Aug 19, 2015

Test build #41271 has finished for PR 8293 at commit 6999d76.

  • This patch fails PySpark unit tests.
  • This patch does not merge cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Aug 19, 2015

Test build #41281 has finished for PR 8293 at commit 562b074.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • case class PromotePrecision(child: Expression) extends UnaryExpression
    • case class CheckOverflow(child: Expression, dataType: DecimalType) extends UnaryExpression

@mengxr
Copy link
Contributor

mengxr commented Aug 19, 2015

LGTM. Merged into master and branch-1.5. Thanks!

@asfgit asfgit closed this in 8e0a072 Aug 19, 2015
asfgit pushed a commit that referenced this pull request Aug 19, 2015
@ericl @mengxr
[SPARK-9895] User Guide for RFormula Feature Transformer
56a37b0 
mengxr

Author: Eric Liang <ekl@databricks.com>

Closes #8293 from ericl/docs-2.

(cherry picked from commit 8e0a072)
Signed-off-by: Xiangrui Meng <meng@databricks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ericl @SparkQA @mengxr