[CORE][MINOR] Whitespace fixes in RangePartitioner #8480
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I think this is too trivial even for a PR. This doesn't fail style checks right? this isn't worth everyone's cycles. |
Contributor
Author
|
@srowen Thanks for your suggestion. There was a similar commit before and I just want to make the code more consistent. |
Member
|
Yes, I think that commit was to pass style checks though. I assume this doesn't fail anything? I mean, I don't mind just merging this, but in my personal opinion I'd like to lightly push back on very small non-functional changes. |
ihainan
changed the title
|
Can one of the admins verify this patch? |
Member
|
Why reopened? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a trivial change so I didn't create a corresponding JIRA issue.