-
Notifications
You must be signed in to change notification settings - Fork 29.1k
Default log4j.properties incorrectly sends all output to stderr and none to stdout #852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Only send ERROR and higher to stderr - Send everything to stdout
|
Merged build triggered. |
|
Merged build started. |
|
I actually thought this was intentional and it's been the case since Spark's inception. @mateiz can you comment on this? |
|
Even I assumed it was intentional since output from user code goes Regards
|
|
Merged build finished. |
|
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/15137/ |
|
This behavior has been in there for a while, so I'm curious, is there a strong reason to change it? It would be a change in behavior that some users might not expect. Users can always configure their own log4j.properties if they don't want this one. |
Ideally these two identical files shouldn't be kept manually in sync, but oh well
|
Merged build triggered. |
|
Merged build started. |
|
The only reason to change it is that it doesn't follow people's If you think the continuity break of changing the logging will jar existing On Fri, May 23, 2014 at 5:08 PM, Matei Zaharia notifications@github.comwrote:
|
|
Merged build finished. |
|
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/15175/ |
But it follows expectations of people who come from Hadoop. Hadoop has already used such log strategy for a long time: https://github.com/apache/hadoop-common/blob/d92a8a29978e35ed36c4d4721a21c356c1ff1d4d/hadoop-common-project/hadoop-minikdc/src/main/resources/log4j.properties |
|
It's likely we already have many users scripting around this default behavior of sending spark logs to stderr. If this was something where we clearly got it wrong, we could consider changing it, but here it seems like more of a preference than a bug. So I think we probably shouldn't change this at this point, even though I see the reason why sending all logs to stdout could be preferable. |
|
Sounds good, I'll close. Would changing the 2 digit years to 4 digit cause heartache? |
https://issues.apache.org/jira/browse/SPARK-1899