[SPARK-10571][Core] Fix incorrect appId in Spark REST / JSON API#8735
[SPARK-10571][Core] Fix incorrect appId in Spark REST / JSON API#8735viirya wants to merge 4 commits intoapache:masterfrom
Conversation
|
Test build #42383 has finished for PR 8735 at commit
|
|
I didn't highlight this super clearly in my JIRA report, but AFIAK the scope of this issue also extends to the URL parameters also mixing these up. We'll have to add new tests and backwards-compatibility rules in order to fix this without creating a new |
|
@JoshRosen OK. Looks like this patch now only solves part of the problem. Would you like to point out where it is the URL parameters which mixes these up? I can find that myself if you are not available. Thanks. |
|
Test build #42402 has finished for PR 8735 at commit
|
|
Test build #42401 has finished for PR 8735 at commit
|
|
Test build #42409 has finished for PR 8735 at commit
|
There was a problem hiding this comment.
Yeah, this is the compatibility concern that I was worried about.
There was a problem hiding this comment.
This is the fix that I was going to propose, too. Good work.
|
I just found #8688 has been merged and looks like it doesn't consider backwards-compatibility. |
|
I think this and SPARK-10571 are duplicates of SPARK-10531; let's at least retag this, or close the PR, as that's already resolved. |
JIRA: https://issues.apache.org/jira/browse/SPARK-10571
The app id shown in Spark REST / JSON API is not correct. This patch fixes it.