Skip to content

[SPARK-10571][Core] Fix incorrect appId in Spark REST / JSON API#8735

Closed
viirya wants to merge 4 commits intoapache:masterfrom
viirya:fix-ui-appid
Closed

[SPARK-10571][Core] Fix incorrect appId in Spark REST / JSON API#8735
viirya wants to merge 4 commits intoapache:masterfrom
viirya:fix-ui-appid

Conversation

@viirya
Copy link
Member

@viirya viirya commented Sep 13, 2015

JIRA: https://issues.apache.org/jira/browse/SPARK-10571

The app id shown in Spark REST / JSON API is not correct. This patch fixes it.

@SparkQA
Copy link

SparkQA commented Sep 13, 2015

Test build #42383 has finished for PR 8735 at commit 2913d0b.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@JoshRosen
Copy link
Contributor

I didn't highlight this super clearly in my JIRA report, but AFIAK the scope of this issue also extends to the URL parameters also mixing these up. We'll have to add new tests and backwards-compatibility rules in order to fix this without creating a new v2 API.

@viirya
Copy link
Member Author

viirya commented Sep 14, 2015

@JoshRosen OK. Looks like this patch now only solves part of the problem. Would you like to point out where it is the URL parameters which mixes these up? I can find that myself if you are not available. Thanks.

@SparkQA
Copy link

SparkQA commented Sep 14, 2015

Test build #42402 has finished for PR 8735 at commit 205cd6d.

  • This patch fails Scala style tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Sep 14, 2015

Test build #42401 has finished for PR 8735 at commit 136d2d3.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class MultilayerPerceptronClassifier(JavaEstimator, HasFeaturesCol, HasLabelCol, HasPredictionCol,
    • class MultilayerPerceptronClassificationModel(JavaModel):
    • class MinMaxScaler(JavaEstimator, HasInputCol, HasOutputCol):
    • class MinMaxScalerModel(JavaModel):
    • ("thresholds", "Thresholds in multi-class classification to adjust the probability of " +
    • class HasElasticNetParam(Params):
    • class HasFitIntercept(Params):
    • class HasStandardization(Params):
    • class HasThresholds(Params):
    • thresholds = Param(Params._dummy(), "thresholds", "Thresholds in multi-class classification to adjust the probability of predicting each class. Array must have length equal to the number of classes, with values >= 0. The class with largest value p/t is predicted, where p is the original probability of that class and t is the class' threshold.")
    • self.thresholds = Param(self, "thresholds", "Thresholds in multi-class classification to adjust the probability of predicting each class. Array must have length equal to the number of classes, with values >= 0. The class with largest value p/t is predicted, where p is the original probability of that class and t is the class' threshold.")
    • case class Stddev(child: Expression) extends StddevAgg(child)
    • case class StddevPop(child: Expression) extends StddevAgg(child)
    • case class StddevSamp(child: Expression) extends StddevAgg(child)
    • abstract class StddevAgg(child: Expression) extends AlgebraicAggregate
    • abstract class StddevAgg1(child: Expression) extends UnaryExpression with PartialAggregate1
    • case class Stddev(child: Expression) extends StddevAgg1(child)
    • case class StddevPop(child: Expression) extends StddevAgg1(child)
    • case class StddevSamp(child: Expression) extends StddevAgg1(child)
    • case class ComputePartialStd(child: Expression) extends UnaryExpression with AggregateExpression1
    • case class ComputePartialStdFunction (
    • case class MergePartialStd(
    • case class MergePartialStdFunction(
    • case class StddevFunction(
    • case class IntersectNode(conf: SQLConf, left: LocalNode, right: LocalNode)
    • case class SampleNode(
    • case class TakeOrderedAndProjectNode(

@SparkQA
Copy link

SparkQA commented Sep 14, 2015

Test build #42409 has finished for PR 8735 at commit e8724bc.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this is the compatibility concern that I was worried about.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the fix that I was going to propose, too. Good work.

@viirya
Copy link
Member Author

viirya commented Sep 18, 2015

I just found #8688 has been merged and looks like it doesn't consider backwards-compatibility.

@srowen
Copy link
Member

srowen commented Sep 18, 2015

I think this and SPARK-10571 are duplicates of SPARK-10531; let's at least retag this, or close the PR, as that's already resolved.

@viirya viirya closed this Sep 18, 2015
@viirya viirya deleted the fix-ui-appid branch December 27, 2023 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants