[SPARK-10623] [SQL] Fixes ORC predicate push-down

[liancheng]

When pushing down a leaf predicate, ORC SearchArgument builder requires an extra "parent" predicate (any one among AND/OR/NOT) to wrap the leaf predicate. E.g., to push down a < 1, we must build AND(a < 1) instead. Fortunately, when actually constructing the SearchArgument, the builder will eliminate all those unnecessary wrappers.

This PR is based on #8783 authored by @zhzhan. I also took the chance to simply OrcFilters a little bit to improve readability.

[liancheng]

The in(attribute, _) part is wrong, because in accepts varargs instead of a list.

[SparkQA]

Test build #42613 has finished for PR 8799 at commit 5febd85.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[SparkQA]

Test build #42625 has finished for PR 8799 at commit c3f6692.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[zhzhan]

LGTM Thanks for fixing this.

[yhuai]

Will this In get changed toInSet by the optimizer when all values are literals?

[liancheng]

This is a sources.In rather than expressions.In, so it should be fine.

[yhuai]

ah ok.

[yhuai]

two comments. Otherwise, looks good.

[SparkQA]

Test build #42688 has finished for PR 8799 at commit a694ba2.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[yhuai]

Does this test check if the predicate is really pushded down? Or it just check answers?

[liancheng]

It just checks answers. It's annoying that I couldn't find a programmatical way to verify whether its pushed down or not. Checked through logs manually though.

[yhuai]

ok. Merging to master and branch 1.5.