SPARK-10701 Expose SparkContext#stopped flag with @DeveloperApi#8822
Closed
tedyu wants to merge 1 commit intoapache:masterfrom
tedyu:master
Closed
SPARK-10701 Expose SparkContext#stopped flag with @DeveloperApi#8822tedyu wants to merge 1 commit intoapache:masterfrom tedyu:master
tedyu wants to merge 1 commit intoapache:masterfrom
tedyu:master
Conversation
tedyu
changed the title
Contributor
There was a problem hiding this comment.
can we expose a slightly nicer API? Right now this is an atomic boolean and the user has to do something like
sc.stopped.get which is super clunky. It would be better if they can do sc.isStopped or something
Contributor
|
@srowen @JoshRosen do you guys think this is a good idea? |
Contributor
|
-1 I don't think we should just expose an atomic variable directly. Apps can accidentally set it to false. |
Contributor
|
@rxin yes that was my comment, but do you think we should add a getter for it? |
Member
|
This is a duplicate. Let's move convo to #8749 Yes, definitely not OK to expose the mutable object. |
Contributor
|
OK let's close this PR then. |
|
Test build #42673 has finished for PR 8822 at commit
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See this thread: http://search-hadoop.com/m/q3RTtqvncy17sSTx1
We should expose this flag to developers
@andrewor14