[Minor] [ML] override toString of AttributeGroup#8826
Closed
ericl wants to merge 2 commits intoapache:masterfrom
Closed
[Minor] [ML] override toString of AttributeGroup#8826ericl wants to merge 2 commits intoapache:masterfrom
ericl wants to merge 2 commits intoapache:masterfrom
Conversation
Contributor
|
LGTM pending Jenins |
|
Test build #42681 has finished for PR 8826 at commit
|
Contributor
There was a problem hiding this comment.
okay, forgot explicit type for public methods
Contributor
Author
|
Oops, fixed. |
|
Test build #42686 has finished for PR 8826 at commit
|
Contributor
|
Merged into master. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes equality test failures much more readable.
@mengxr