[SPARK-10763][ML][JAVA][TEST] Update Java MLLIB/ML tests to use simplified dataframe construction#8886
Conversation
…Java tests in mllib/ml
|
It seems OK to me. I assume we still have at least one test that tests the version with an RDD argument! |
|
@srowen So this changes it so that all of the ml tests that created a Dataframe using an RDDs of Rows now use List's of rows as input to the Dataframe constructor, but in the Dataframe constructor tests both are tested. |
|
Test build #42915 has finished for PR 8886 at commit
|
|
Test build #42916 has finished for PR 8886 at commit
|
There was a problem hiding this comment.
fix indentation. (It seems that your format configuration for Java is different from Scala.)
|
LGTM except indentation. The test for creating DataFrame from JavaRDD should live in DataFrame's unit tests. |
|
Test build #42932 has finished for PR 8886 at commit
|
|
Merged into master. Thanks! |
As introduced in https://issues.apache.org/jira/browse/SPARK-10630 we now have an easier way to create dataframes from local Java lists. Lets update the tests to use those.