Skip to content

[SPARK-10763][ML][JAVA][TEST] Update Java MLLIB/ML tests to use simplified dataframe construction#8886

Closed
holdenk wants to merge 3 commits intoapache:masterfrom
holdenk:SPARK-10763-update-java-mllib-ml-tests-to-use-simplified-dataframe-construction
Closed

[SPARK-10763][ML][JAVA][TEST] Update Java MLLIB/ML tests to use simplified dataframe construction#8886
holdenk wants to merge 3 commits intoapache:masterfrom
holdenk:SPARK-10763-update-java-mllib-ml-tests-to-use-simplified-dataframe-construction

Conversation

@holdenk
Copy link
Contributor

@holdenk holdenk commented Sep 23, 2015

As introduced in https://issues.apache.org/jira/browse/SPARK-10630 we now have an easier way to create dataframes from local Java lists. Lets update the tests to use those.

@srowen
Copy link
Member

srowen commented Sep 23, 2015

It seems OK to me. I assume we still have at least one test that tests the version with an RDD argument!

@holdenk
Copy link
Contributor Author

holdenk commented Sep 23, 2015

@srowen So this changes it so that all of the ml tests that created a Dataframe using an RDDs of Rows now use List's of rows as input to the Dataframe constructor, but in the Dataframe constructor tests both are tested.

@SparkQA
Copy link

SparkQA commented Sep 23, 2015

Test build #42915 has finished for PR 8886 at commit 1b45c36.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Sep 23, 2015

Test build #42916 has finished for PR 8886 at commit 4bf4ae6.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix indentation. (It seems that your format configuration for Java is different from Scala.)

@mengxr
Copy link
Contributor

mengxr commented Sep 23, 2015

LGTM except indentation. The test for creating DataFrame from JavaRDD should live in DataFrame's unit tests.

@holdenk holdenk changed the title [SPARK-10763][ML][JAVA][TEST][WIP] Update Java MLLIB/ML tests to use simplified dataframe construction [SPARK-10763][ML][JAVA][TEST] Update Java MLLIB/ML tests to use simplified dataframe construction Sep 23, 2015
@SparkQA
Copy link

SparkQA commented Sep 23, 2015

Test build #42932 has finished for PR 8886 at commit a668f0d.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@mengxr
Copy link
Contributor

mengxr commented Sep 24, 2015

Merged into master. Thanks!

@asfgit asfgit closed this in d91967e Sep 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants