[SPARK-10736] [ML] Use 1 for all ratings if $(ratingCol) = ""#8937
Closed
yanboliang wants to merge 2 commits intoapache:masterfrom
Closed
[SPARK-10736] [ML] Use 1 for all ratings if $(ratingCol) = ""#8937yanboliang wants to merge 2 commits intoapache:masterfrom
yanboliang wants to merge 2 commits intoapache:masterfrom
Conversation
|
Test build #43078 has finished for PR 8937 at commit
|
Contributor
There was a problem hiding this comment.
It might be easier to define the rating col first:
val r = if ($(ratingCol) != "") col($(ratingCol)).cast(FloatType) else lit(1.0f)
val ratings = dataset.select(..., ..., r).map { row =>
...
}
|
Test build #43115 has finished for PR 8937 at commit
|
Contributor
|
LGTM. Merged into master. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For some implicit dataset, ratings may not exist in the training data. In this case, we can assume all observed pairs to be positive and treat their ratings as 1. This should happen when users set
ratingColto an empty string.