Skip to content

[SPARK-1820] Make GenerateMimaIgnore @DeveloperApi annotation aware.#904

Closed
ScrapCodes wants to merge 3 commits intoapache:masterfrom
ScrapCodes:SPARK-1820/ignore-Developer-Api
Closed

[SPARK-1820] Make GenerateMimaIgnore @DeveloperApi annotation aware.#904
ScrapCodes wants to merge 3 commits intoapache:masterfrom
ScrapCodes:SPARK-1820/ignore-Developer-Api

Conversation

@ScrapCodes
Copy link
Member

@ScrapCodes ScrapCodes commented May 28, 2014

We add all the classes annotated as DeveloperApi to ~/.mima-excludes.

@ScrapCodes ScrapCodes changed the title SPARK-1820 Make GenerateMimaIgnore @DeveloperApi annotation aware. [SPARK-1820][WIP] Make GenerateMimaIgnore @DeveloperApi annotation aware. May 28, 2014
@AmplabJenkins
Copy link

AmplabJenkins commented May 28, 2014

Merged build triggered.

@AmplabJenkins
Copy link

AmplabJenkins commented May 28, 2014

Merged build started.

@ScrapCodes ScrapCodes changed the title [SPARK-1820][WIP] Make GenerateMimaIgnore @DeveloperApi annotation aware. [SPARK-1820] Make GenerateMimaIgnore @DeveloperApi annotation aware. May 28, 2014
@ScrapCodes ScrapCodes mentioned this pull request May 28, 2014
Closed
@AmplabJenkins
Copy link

AmplabJenkins commented May 28, 2014

Merged build finished. All automated tests passed.

@AmplabJenkins
Copy link

AmplabJenkins commented May 28, 2014

All automated tests passed.
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/15250/

@pwendell
Copy link
Contributor

pwendell commented May 28, 2014

@ScrapCodes did you test this at all? I tried to run this locally and it didn't seem to pick up the annotation. I added an annotation in graphx/src/main/scala/org/apache/spark/graphx/Edge.scala.

@DeveloperApi
case class Edge[@specialized(Char, Int, Boolean, Byte, Long, Float, Double) ED] (

Then I ran the GenerateMimaIgnore tool.

pwendell
pwendell reviewed May 28, 2014
View reviewed changes
tools/src/main/scala/org/apache/spark/tools/GenerateMIMAIgnore.scala Outdated
Copy link
Contributor

@pwendell pwendell May 28, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should rename privateClasses to ignoredClasses here?

@ScrapCodes
Copy link
Member Author

ScrapCodes commented May 29, 2014

Hey @pwendell, I just tried running with annotation on Edge.scala as you suggested above and it was correctly detected. I am not sure if I am missing something. But you will need to do assembly after making that change to Edge.scala .

@AmplabJenkins
Copy link

AmplabJenkins commented May 29, 2014

Merged build triggered.

@AmplabJenkins
Copy link

AmplabJenkins commented May 29, 2014

Merged build started.

@AmplabJenkins
Copy link

AmplabJenkins commented May 29, 2014

Merged build finished. All automated tests passed.

@AmplabJenkins
Copy link

AmplabJenkins commented May 29, 2014

All automated tests passed.
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/15277/

@asfgit asfgit closed this in eeee978 May 30, 2014
pdeyhim pushed a commit to pdeyhim/spark-1 that referenced this pull request Jun 25, 2014
@ScrapCodes @pdeyhim
[SPARK-1820] Make GenerateMimaIgnore @DeveloperAPI annotation aware.
3fe7d72 
We add all the classes annotated as `DeveloperApi` to `~/.mima-excludes`.

Author: Prashant Sharma <prashant.s@imaginea.com>
Author: nikhil7sh <nikhilsharmalnmiit@gmail.ccom>

Closes apache#904 from ScrapCodes/SPARK-1820/ignore-Developer-Api and squashes the following commits:

de944f9 [Prashant Sharma] Code review.
e3c5215 [Prashant Sharma] Incorporated patrick's suggestions and fixed the scalastyle build.
9983a42 [nikhil7sh] [SPARK-1820] Make GenerateMimaIgnore @DeveloperAPI annotation aware
xiliu82 pushed a commit to xiliu82/spark that referenced this pull request Sep 4, 2014
@ScrapCodes @conviva-zz
[SPARK-1820] Make GenerateMimaIgnore @DeveloperAPI annotation aware.
a920ad8 
We add all the classes annotated as `DeveloperApi` to `~/.mima-excludes`.

Author: Prashant Sharma <prashant.s@imaginea.com>
Author: nikhil7sh <nikhilsharmalnmiit@gmail.ccom>

Closes apache#904 from ScrapCodes/SPARK-1820/ignore-Developer-Api and squashes the following commits:

de944f9 [Prashant Sharma] Code review.
e3c5215 [Prashant Sharma] Incorporated patrick's suggestions and fixed the scalastyle build.
9983a42 [nikhil7sh] [SPARK-1820] Make GenerateMimaIgnore @DeveloperAPI annotation aware
@ScrapCodes ScrapCodes deleted the SPARK-1820/ignore-Developer-Api branch June 3, 2015 06:01
wangyum pushed a commit that referenced this pull request May 26, 2023
[CARMEL-5915] Add command to detect HDM storage leak (#904)
8c2a7dd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ScrapCodes @AmplabJenkins @pwendell