Skip to content

Conversation

@hhbyyh
Copy link
Contributor

@hhbyyh hhbyyh commented Oct 12, 2015

jira: https://issues.apache.org/jira/browse/SPARK-11029

We should add a method analogous to spark.mllib.clustering.KMeansModel.computeCost to spark.ml.clustering.KMeansModel.
This will be a temp fix until we have proper evaluators defined for clustering.

@SparkQA
Copy link

SparkQA commented Oct 12, 2015

Test build #43562 has finished for PR 9073 at commit 5440dc5.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@jkbradley
Copy link
Member

@hhbyyh I think this should take a DataFrame instead of an RDD to be consistent with the Pipelines API. Also, would it be easy to add a quick unit test? Thanks!

@hhbyyh
Copy link
Contributor Author

hhbyyh commented Oct 12, 2015

@jkbradley Thanks for helping review. Let me know if we need a separate UT.

@SparkQA
Copy link

SparkQA commented Oct 12, 2015

Test build #43593 has finished for PR 9073 at commit 738ab03.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no longer necessary

@jkbradley
Copy link
Member

That should be it---thanks!

@jkbradley
Copy link
Member

LGTM pending tests

@SparkQA
Copy link

SparkQA commented Oct 16, 2015

Test build #43864 has finished for PR 9073 at commit cff3d5a.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@hhbyyh
Copy link
Contributor Author

hhbyyh commented Oct 16, 2015

Thanks for taking the time review.

@jkbradley
Copy link
Member

Merging with master. Thanks for the PR!

@asfgit asfgit closed this in e1e77b2 Oct 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants