Skip to content

Conversation

@rcompton
Copy link

Removed jul-to-slf4j and jcl-over-slf4j to allow Pig scripts to register jars containing the Spark-1.0 assembly, cf https://issues.apache.org/jira/browse/SPARK-1952

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@srowen
Copy link
Member

srowen commented May 29, 2014

As Patrick alluded to, those imports are on purpose, to direct logging from this like Pig that use JCL to the logging that the rest of the app uses. Because things like JCL have been excluded, also excluding these would cause libraries that use JCL to fail, so I don't think this can be included like this. The intended action would be to exclude JCL in your downstream app and keep this import. Of course you can get other effects, like rejiggering the whole setup to direct to JCL and not log4j. It's more, different work, but possible.

@mateiz
Copy link
Contributor

mateiz commented Aug 30, 2014

@rcompton I believe this has been addressed by Sigmoid's recent work for Pig on Spark: https://issues.apache.org/jira/browse/PIG-4059. Given that, do we still need this patch?

@rcompton
Copy link
Author

@mateiz no, for the reasons mentioned by Sean as well as the new work by Sigmoid, you don't need this patch.

@rcompton rcompton closed this Aug 30, 2014
@mateiz
Copy link
Contributor

mateiz commented Aug 30, 2014

Alright, thanks for taking a look at this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants