-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-11073] [core] [yarn] Remove akka dependency in secret key generation. #9257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ration. Use standard JDK APIs for that (with a little help from Guava). Most of the changes here are in test code, since there were no tests specific to that part of the code.
|
cc @tgravescs |
|
Test build #44270 has finished for PR 9257 at commit
|
|
retest this please |
|
Test build #44283 has finished for PR 9257 at commit
|
|
Test build #44304 has finished for PR 9257 at commit
|
|
not sure what failed. retest this please |
|
Test build #44303 has finished for PR 9257 at commit
|
|
Test build #44305 has finished for PR 9257 at commit
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any reason not to leave the debug messages?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They didn't feel particularly useful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer to see this one left. Otherwise there is no easy way to see what its doing for the secret. In general I'm against removing debug stuff unless its really really noisy. This should only be printed once and can be useful debugging user settings or issues with secrets.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
|
Test build #44512 has finished for PR 9257 at commit
|
|
+1 pending Jenkins. |
|
Test build #44528 has finished for PR 9257 at commit
|
|
Test build #44771 has finished for PR 9257 at commit
|
|
Merging this. |
Use standard JDK APIs for that (with a little help from Guava). Most of the
changes here are in test code, since there were no tests specific to that
part of the code.