Skip to content

Conversation

@vanzin
Copy link
Contributor

@vanzin vanzin commented Oct 23, 2015

Use standard JDK APIs for that (with a little help from Guava). Most of the
changes here are in test code, since there were no tests specific to that
part of the code.

…ration.

Use standard JDK APIs for that (with a little help from Guava). Most of the
changes here are in test code, since there were no tests specific to that
part of the code.
@rxin
Copy link
Contributor

rxin commented Oct 24, 2015

cc @tgravescs

@SparkQA
Copy link

SparkQA commented Oct 24, 2015

Test build #44270 has finished for PR 9257 at commit 98761dd.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):\n * class DefaultSource extends HadoopFsRelationProvider with DataSourceRegister\n * class TextOutputWriter(path: String, dataSchema: StructType, context: TaskAttemptContext)\n

@vanzin
Copy link
Contributor Author

vanzin commented Oct 24, 2015

retest this please

@SparkQA
Copy link

SparkQA commented Oct 24, 2015

Test build #44283 has finished for PR 9257 at commit 98761dd.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Oct 24, 2015

Test build #44304 has finished for PR 9257 at commit c6c9823.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@vanzin
Copy link
Contributor Author

vanzin commented Oct 24, 2015

not sure what failed. retest this please

@SparkQA
Copy link

SparkQA commented Oct 25, 2015

Test build #44303 has finished for PR 9257 at commit 35002a9.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Oct 25, 2015

Test build #44305 has finished for PR 9257 at commit c6c9823.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any reason not to leave the debug messages?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They didn't feel particularly useful.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer to see this one left. Otherwise there is no easy way to see what its doing for the secret. In general I'm against removing debug stuff unless its really really noisy. This should only be printed once and can be useful debugging user settings or issues with secrets.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@SparkQA
Copy link

SparkQA commented Oct 28, 2015

Test build #44512 has finished for PR 9257 at commit c6cde97.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@tgravescs
Copy link
Contributor

+1 pending Jenkins.

@SparkQA
Copy link

SparkQA commented Oct 28, 2015

Test build #44528 has finished for PR 9257 at commit b4a29bf.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Nov 1, 2015

Test build #44771 has finished for PR 9257 at commit 0878148.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@vanzin
Copy link
Contributor Author

vanzin commented Nov 1, 2015

Merging this.

@asfgit asfgit closed this in f8d93ed Nov 1, 2015
@vanzin vanzin deleted the SPARK-11073 branch November 2, 2015 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants