Skip to content

Conversation

@marmbrus
Copy link
Contributor

This is minor, but I ran into while writing Datasets and while it wasn't needed for the final solution, it was super confusing so we should fix it.

Basically we recurse into Seq to see if they have children. This breaks because we don't preserve the original subclass of Seq (and StructType <:< Seq[StructField]). Since a struct can never contain children, lets just not recurse into it.

@cloud-fan
Copy link
Contributor

LGTM

@SparkQA
Copy link

SparkQA commented Oct 28, 2015

Test build #44531 has finished for PR 9334 at commit b5c6f82.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):\n * case class CoGroup[K, Left, Right, R](\n * class CoGroupedIterator(\n * case class CoGroup[K, Left, Right, R](\n

@yhuai
Copy link
Contributor

yhuai commented Oct 28, 2015

Merging to master.

@asfgit asfgit closed this in 032748b Oct 28, 2015
@marmbrus marmbrus deleted the structMakeCopy branch March 8, 2016 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants