-
Notifications
You must be signed in to change notification settings - Fork 29k
[DOC] Missing link to R DataFrame API doc #9394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Test build #44749 has finished for PR 9394 at commit
|
|
On this note can we update the roxygen doc for DataFrames ? http://spark.apache.org/docs/latest/api/R/DataFrame.html seems pretty incomplete. |
|
why don't we point to http://spark.apache.org/docs/latest/sparkr.html for now instead? |
|
@felixb Other docs for Scala, Java and Python toward API documents. So I thought it might be better to make it indicate toward http://spark.apache.org/docs/latest/api/R/DataFrame.html too. |
|
Yeah but the DataFrame.html doesn't seem very useful the way it is right now -- can you just update the roxygen docs in this PR as well ? |
|
@shivaram Sure. I'll submit. |
|
This failure does not seem to be related to the patch. |
|
Jenkins, retest this please |
1 similar comment
|
Jenkins, retest this please |
|
Test build #44880 has finished for PR 9394 at commit
|
|
I think this error is related |
|
it should be |
|
Test build #44896 has finished for PR 9394 at commit
|
|
The latest error is @Lewuathe you can verify this locally using |
|
@shivaram Thank you. But that error was not occurred on local. Only warning and generating process ended up successful. Anyway I can update it. |
|
Test build #44903 has finished for PR 9394 at commit
|
R/pkg/DESCRIPTION
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure we need to modify this file in this PR - It encodes some dependencies among R files which is sometimes fragile.
|
Thanks @Lewuathe -- LGTM. This is good to go if you can revert the change to the |
|
Test build #44976 has finished for PR 9394 at commit
|
|
Thanks again. Merging this |
|
@felixcheung @shivaram Thank you so much! |
No description provided.