Skip to content

Conversation

@Lewuathe
Copy link
Contributor

@Lewuathe Lewuathe commented Nov 1, 2015

No description provided.

@SparkQA
Copy link

SparkQA commented Nov 1, 2015

Test build #44749 has finished for PR 9394 at commit 2361e6e.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):\n * logInfo(s\"Hive class not found $e\")\n * logDebug(\"Hive class not found\", e)\n

@felixcheung
Copy link
Member

@shivaram

@shivaram
Copy link
Contributor

shivaram commented Nov 1, 2015

On this note can we update the roxygen doc for DataFrames ? http://spark.apache.org/docs/latest/api/R/DataFrame.html seems pretty incomplete.

@felixcheung
Copy link
Member

why don't we point to http://spark.apache.org/docs/latest/sparkr.html for now instead?

@Lewuathe
Copy link
Contributor Author

Lewuathe commented Nov 2, 2015

@felixb Other docs for Scala, Java and Python toward API documents. So I thought it might be better to make it indicate toward http://spark.apache.org/docs/latest/api/R/DataFrame.html too.

@shivaram
Copy link
Contributor

shivaram commented Nov 2, 2015

Yeah but the DataFrame.html doesn't seem very useful the way it is right now -- can you just update the roxygen docs in this PR as well ?

@Lewuathe
Copy link
Contributor Author

Lewuathe commented Nov 3, 2015

@shivaram Sure. I'll submit.

@Lewuathe
Copy link
Contributor Author

Lewuathe commented Nov 3, 2015

This failure does not seem to be related to the patch.

@shivaram
Copy link
Contributor

shivaram commented Nov 3, 2015

Jenkins, retest this please

1 similar comment
@shivaram
Copy link
Contributor

shivaram commented Nov 3, 2015

Jenkins, retest this please

@SparkQA
Copy link

SparkQA commented Nov 3, 2015

Test build #44880 has finished for PR 9394 at commit 0a29085.

  • This patch fails some tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@shivaram
Copy link
Contributor

shivaram commented Nov 3, 2015

I think this error is related

First time using roxygen2 4.0. Upgrading automatically...
Error: Failure in roxygen block beginning DataFrame.R:23
Mismatched braces: "@seealso \{createDataFrame}, \link{jsonFile}, \link{table}"
Execution halted

@felixcheung
Copy link
Member

it should be @seealso \link{createDataFrame}

@SparkQA
Copy link

SparkQA commented Nov 3, 2015

Test build #44896 has finished for PR 9394 at commit 0607334.

  • This patch fails some tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@shivaram
Copy link
Contributor

shivaram commented Nov 3, 2015

The latest error is

Error: Failure in roxygen block beginning DataFrame.R:23
@export may only span a single line

@Lewuathe you can verify this locally using ./R/create-docs.sh before submitting to Jenkins

@Lewuathe
Copy link
Contributor Author

Lewuathe commented Nov 3, 2015

@shivaram Thank you. But that error was not occurred on local. Only warning and generating process ended up successful. Anyway I can update it.

@SparkQA
Copy link

SparkQA commented Nov 3, 2015

Test build #44903 has finished for PR 9394 at commit 818b34f.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure we need to modify this file in this PR - It encodes some dependencies among R files which is sometimes fragile.

@shivaram
Copy link
Contributor

shivaram commented Nov 3, 2015

Thanks @Lewuathe -- LGTM. This is good to go if you can revert the change to the DESCRIPTION file.

@SparkQA
Copy link

SparkQA commented Nov 4, 2015

Test build #44976 has finished for PR 9394 at commit 12f3a74.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@shivaram
Copy link
Contributor

shivaram commented Nov 4, 2015

Thanks again. Merging this

@Lewuathe
Copy link
Contributor Author

Lewuathe commented Nov 4, 2015

@felixcheung @shivaram Thank you so much!

@asfgit asfgit closed this in d648a4a Nov 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants