-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-11410] [PYSPARK] Add python bindings for repartition and sortW… #9504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Test build #45147 has finished for PR 9504 at commit
|
|
Title should have the [SQL] tag as well |
|
you can run the python test locally by python/run-tests --module pyspark-sql (take a look at -h to see the exact command) before you run that, you need to build the assembly jar for Spark, e.g. sbt/sbt assembly/assembly |
|
cc @davies |
python/pyspark/sql/dataframe.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one is not needed here, since you do not have u"" in the doc test.
… sortWithinPartitions.
|
Test build #45239 has finished for PR 9504 at commit
|
|
Build finished. 201 tests run, 0 skipped, 0 failed. |
python/pyspark/sql/dataframe.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be 1.3, we can have .. versionchanged:: version xxx in the end of doc.
In order to have good order, we may not use since here, but
.. versionadd:: 1.3
.. versionchanged:: 1.6 xxx
|
LGTM |
|
Since the last commit only updated the doc, I will merge this into master and 1.6 branch, thanks! |
…ithinPartitions. Author: Nong Li <nong@databricks.com> Closes #9504 from nongli/spark-11410. (cherry picked from commit 1ab72b0) Signed-off-by: Davies Liu <davies.liu@gmail.com>
…ithinPartitions.