-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-11625][SQL] add java test for typed aggregate #9591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, this is unfortunate. I think that the only thing we can do is use the DataFrame version of agg and then cast afterwards.
Dataset<Tuple4<String, Integer, Long, Long>> agged2 = grouped.agg(
new IntSumOf().toColumn(e.INT(), e.INT()),
expr("sum(_2)"),
count("*")).as(e.tuple(e.STRING(), e.INT(), e.LONG(), e.LONG()));|
Test build #45511 has finished for PR 9591 at commit
|
|
Test build #45523 has finished for PR 9591 at commit
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should do something about this. I think that if we rename the object to Encoders then Scala will build static forwarders and we can just call Encoders.STRING()
|
Test build #45595 has finished for PR 9591 at commit
|
|
retest this please. |
|
Test build #45623 has finished for PR 9591 at commit
|
|
Test build #45632 has finished for PR 9591 at commit
|
|
retest this please |
|
Test build #45635 has finished for PR 9591 at commit
|
|
Test build #2045 has finished for PR 9591 at commit
|
|
Test build #2046 has finished for PR 9591 at commit
|
|
Test build #45709 has finished for PR 9591 at commit
|
|
retest this please. |
|
Test build #45723 has finished for PR 9591 at commit
|
|
retest this please. |
|
Test build #45740 has finished for PR 9591 at commit
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should just move this to Queryable with docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh sorry, maybe we need to make GroupQueryable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rxin I think we need to expose this for the java users to work, while still getting nice inference for scala
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to provide a tEncoder here, which is not the case of GroupedData.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, we still need to add scaladoc then.
|
Test build #45821 has finished for PR 9591 at commit
|
|
Test build #45907 has finished for PR 9591 at commit
|
|
retest this please. |
|
Test build #45925 has finished for PR 9591 at commit
|
|
Thanks! Merging to master and 1.6. |
No description provided.