Skip to content

Conversation

@yanboliang
Copy link
Contributor

We have DecisionTreeClassificationExample and DecisionTreeRegressionExample for Scala/Java/Python under examples/ml, so removed duplicate DecisionTreeExample.

@SparkQA
Copy link

SparkQA commented Nov 13, 2015

Test build #45815 has finished for PR 9682 at commit e0c0c3f.

  • This patch fails to build.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Nov 13, 2015

Test build #45820 has finished for PR 9682 at commit e0c0c3f.

  • This patch fails to build.
  • This patch merges cleanly.
  • This patch adds no public classes.

@mengxr
Copy link
Contributor

mengxr commented Nov 13, 2015

@yanboliang There are two types of example code under examples/:

  1. Example applications (the ones with command-line parsing). Those are served as template code for users to build their own standalone applications. We should keep those for important algorithms.
  2. Tutorial code. Those are for the user guide, usually without options to play with. We should keep at most one copy per algorithm.

@yanboliang
Copy link
Contributor Author

I think we should keep the DecisionTreeExample, so closing this PR. Thanks for your comments. @mengxr

@yanboliang yanboliang closed this Nov 13, 2015
@yanboliang yanboliang deleted the spark-11719 branch November 13, 2015 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants