-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-11832] [Core] Process arguments in spark-shell for Scala 2.11 #9824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why "-usejavacp" is not added here ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"-usejavacp" is actually passed from the build sparkShell task. I didn't want to change the conditions under which it is called (i.e. it may not be needed if other arguments are supplied)
|
ok to test |
|
Test build #47168 has finished for PR 9824 at commit
|
|
This PR is pretty low priority but still a neat thing to have when developing. |
|
Code looks ok to me, but this is not an area where I have much familiarity (e.g. I'm not familiar with how the underlying repl works in detail). Perhaps others know? @JoshRosen @andrewor14 |
|
+1 for treating the errors. How do you usually deal with overlapping pull requests? Should I just copy your error-handling code manually and mention it? |
|
Copying is fine by me, it's a really small piece of code. I already closed my PR. |
|
@dragos, should be good now |
|
Test build #47436 has started for PR 9824 at commit |
|
LGTM. Let's get this in, two PRs in 2 weeks is a good sign this is very useful ;-) |
|
Ok, I'm merging this to master. |
Process arguments passed to the spark-shell. Fixes running the spark-shell from within a build environment.