-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-7499][SPARKR][WIP] Investigate how to specify columns in SparkR without $ or strings. #9835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…hout $ or strings.
|
cc @adrian555 |
|
Test build #46316 has finished for PR 9835 at commit
|
|
I was going to work on this JIRA but was busy on other deliverable. :) Thanks @sun-rui |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since 'select' is an external API, should we not put the code for the function after the roxygen codes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a WIP, I will update doc and code once all test cases pass
|
I think the goal is to have the same for not only |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd suggest use 'drop' as the argument name instead since that is more R-like.
|
@felixcheung Yes, I agree. We should make this work for all dplyr-like functions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these seem very expensive to have this per each call?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, will have a cache for the environment per DataFrame.
|
I realize that this takes more effort than I expected as we'd better support specifying columns without $ for all DataFrame methods that take any argument of "Column" type. I will do more investigation. |
|
Test build #46600 has finished for PR 9835 at commit
|
|
@sun-rui Could we close this PR for now if its not active ? It'll just clear the PR queue. |
|
Close it. Will send new PR later. |
This WIP PR is inspired by https://issues.apache.org/jira/browse/SPARK-11260.