Skip to content

Display vote creator and authz clear #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gstein merged 1 commit into from
Feb 28, 2026
+18 −18
Merged

Display vote creator and authz clear #83

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 18 additions & 18 deletions v3/server/templates/voter.ezt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,14 +78,14 @@
</div>
</div>
<div class="card-footer text-muted small d-flex justify-content-between align-items-center">
<span>
[open_elections.owner_name]
[if-any open_elections.authz]
<span>[open_elections.authz] can vote</span>
[end]
<span class="text-muted" style="font-size: 0.8em;">
Created By [open_elections.owner_name]
Copy link

Copilot AI Feb 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The text "Created By" uses title-case mid-sentence; "By" should be lowercase: "Created by". The same issue exists in the upcoming_elections section (line 137) and past_elections section (line 177).

Copilot uses AI. Check for mistakes.
<span class="text-muted" style="font-size: 0.8em;">([open_elections.owner_pid])</span>
[if-any open_elections.authz]
&nbsp;&middot;&nbsp; [open_elections.authz]
[end]
&nbsp;&middot;&nbsp; eid: [open_elections.eid]
</span>
Comment on lines +81 to 88
Copy link

Copilot AI Feb 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The card-footer uses d-flex justify-content-between align-items-center, which distributes space between its direct children. In the new layout, when authz is absent the [if-any open_elections.authz] block produces no DOM element, leaving only the single creator <span> as a child. With only one flex child, justify-content-between has no effect and the creator info will be left-aligned instead of pushed to the right edge of the footer. The original code always had two <span> elements (owner info on the left, eid on the right), so the footer's layout was always well-defined.

To preserve the intended two-column flex layout, consider always rendering the left slot (e.g., an empty <span> when authz is absent, or unconditionally rendering a <span> that is just empty when authz is not set), so there are always two flex children for justify-content-between to act on. This same issue applies to the upcoming_elections and past_elections sections as well (lines 133–140 and 173–180).

Copilot uses AI. Check for mistakes.
<span class="text-muted" style="font-size: 0.8em;">eid: [open_elections.eid]</span>
</div>
</div>
</div>
Expand Down Expand Up @@ -130,14 +130,14 @@
</p>
</div>
<div class="card-footer text-muted small d-flex justify-content-between align-items-center">
<span>
[upcoming_elections.owner_name]
[if-any upcoming_elections.authz]
<span>[upcoming_elections.authz] can vote</span>
[end]
<span class="text-muted" style="font-size: 0.8em;">
Created By [upcoming_elections.owner_name]
<span class="text-muted" style="font-size: 0.8em;">([upcoming_elections.owner_pid])</span>
[if-any upcoming_elections.authz]
&nbsp;&middot;&nbsp; [upcoming_elections.authz]
[end]
&nbsp;&middot;&nbsp; eid: [upcoming_elections.eid]
</span>
<span class="text-muted" style="font-size: 0.8em;">eid: [upcoming_elections.eid]</span>
</div>
</div>
</div>
Expand Down Expand Up @@ -170,14 +170,14 @@
</p>
</div>
<div class="card-footer text-muted small d-flex justify-content-between align-items-center">
<span>
[past_elections.owner_name]
[if-any past_elections.authz]
<span>[past_elections.authz] can vote</span>
Copy link

Copilot AI Feb 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The authz span "[past_elections.authz] can vote" is shown on past elections (lines 173–175). Since past elections are already closed, displaying "can vote" is misleading — there is no voting action available on a past election. Consider suppressing the authz display for past elections, or changing the label (e.g., "could vote") if it is meant to be informational.

Suggested change
<span>[past_elections.authz] can vote</span>
<span>[past_elections.authz] could vote</span>

Copilot uses AI. Check for mistakes.
[end]
<span class="text-muted" style="font-size: 0.8em;">
Created By [past_elections.owner_name]
<span class="text-muted" style="font-size: 0.8em;">([past_elections.owner_pid])</span>
[if-any past_elections.authz]
&nbsp;&middot;&nbsp; [past_elections.authz]
[end]
&nbsp;&middot;&nbsp; eid: [past_elections.eid]
</span>
<span class="text-muted" style="font-size: 0.8em;">eid: [past_elections.eid]</span>
</div>
</div>
</div>
Expand Down
Loading