[STORM-1232] port backtype.storm.scheduler.DefaultScheduler to java #1058
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Now the |
Contributor
There was a problem hiding this comment.
map is not needed, set would suffice.
Member
Author
There was a problem hiding this comment.
Yeah. Set should suffice. Fixed.
1. change from map to set 2. reuse `Utils.integerDivided`
Member
Author
|
Thanks @abhishekagarwal87 for your review. Comments addressed. |
Conflicts: storm-core/src/clj/org/apache/storm/daemon/nimbus.clj storm-core/src/clj/org/apache/storm/scheduler/DefaultScheduler.clj storm-core/src/clj/org/apache/storm/scheduler/IsolationScheduler.clj
Member
Author
|
Since resolving conflicts merge cause some issues, I have created a new PR(#1108). Please take a look. |
Member
Author
|
The new PR also fixed the dependence issue. |
revans2
pushed a commit
to revans2/incubator-storm
that referenced
this pull request
May 7, 2018
YSTORM-4667: Backwards Compatability for the Constraint Solver in 2.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.