-
Notifications
You must be signed in to change notification settings - Fork 4.1k
STORM-1539 - Improve Storm ACK-ing performance #1101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
+1. |
|
Nice, +1 |
|
I was able to run the unit tests successfully for this.. but wanted to ensure a committer is able to review the Java ACKing logic implementation and confirm it looks good. |
|
+1 I haven't looked at the conflicts yet, But we may need separate pull requests for the mast and 1.x branches. But that should be trivial. Can you add this to STORM-1491? |
|
+1 |
|
Added it to STORM-1491. |
|
will update PR by removing unused clojure function and squashing commits. |
74bfd23 to
3a8d3bf
Compare
|
+1 please have a version for 1.x, and please upmerge for 2.x. |
3a8d3bf to
d110b1f
Compare
|
@revans2 .. PR updated after rebase to master branch |
|
+1 again |
|
+1 |
GRIDCI-2949 -- Update ilist emails
Implemented the ACK-ing logic in Java.
See Jira for profiler info on performance boost.