[STORM-1250]: port backtype.storm.serialization-test to java #1150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| import com.google.common.collect.ImmutableMap; | ||
| import org.apache.storm.utils.Utils; | ||
| import org.apache.storm.validation.ConfigValidation; | ||
| import org.apache.storm.validation.ConfigValidation.*; |
Member
Author
|
@abhishekagarwal87 Thanks for your hint. I have moved |
Contributor
|
Thanks @wuchong Looks good to me. |
Member
Author
|
@revans2 can you have a look ? |
| List ret = null; | ||
| try { | ||
| ret = deserialize(serialize(vals, conf), conf); | ||
| } catch (IOException e) { |
Contributor
There was a problem hiding this comment.
I would prefer to have the IOException thrown by roundtrip. Catching it will still cause the test to fail, but it will be harder to debug.
Contributor
|
Just one minor comment. I am +1 even without the update. |
Member
Author
|
@revans2 addressed |
Contributor
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
validate-kryo-conf-basicandvalidate-kryo-conf-failtoTestConfigValidate.java, and merge this two tests into onetest-clojure-serialization. So I translate it and commet it.