Skip to content

STORM-453 - migrated to curator 2.5.0 #165

Merged
asfgit merged 1 commit into
apache:masterfrom
devsprint:curator-2.5.0
Aug 18, 2014
Merged

STORM-453 - migrated to curator 2.5.0 #165
asfgit merged 1 commit into
apache:masterfrom
devsprint:curator-2.5.0

Conversation

@devsprint
Copy link
Copy Markdown
Contributor

Migrated code to curator 2.5.0 (updated zookeeper version, netty version, guava version). I was not able to find any issue running existing topologies on this code.
This change will allow Cassandra driver integration in bolt/spout without dependencies shadowing or other tricks...

@revans2
Copy link
Copy Markdown
Contributor

revans2 commented Jul 18, 2014

The changes seem OK to me, but I would like to see a JIRA filed for this and the JIRA number (i.e. STORM-12345) added to the title of the pull request. I really should have gotten to this a long time ago, sorry it has taken so long.

@devsprint
Copy link
Copy Markdown
Contributor Author

@revans2 Sorry, I haven't seen this update. JIRA ticket is below.
https://issues.apache.org/jira/browse/STORM-453

@devsprint devsprint changed the title migrated to curator 2.5.0 STORM-453 - migrated to curator 2.5.0 Aug 13, 2014
@viktortnk
Copy link
Copy Markdown
Contributor

does it make sense to update this PR with newer versions of curator, guava and netty before merge?

Btw, current version of cassandra driver mentioned has guava 16.0.1 and netty 3.9.0 in it's list

@revans2
Copy link
Copy Markdown
Contributor

revans2 commented Aug 18, 2014

I tried the change both with and without the updates suggested by @viktortnk Both passed and I am fine either way. @devsprint if you want me to I will merge it in as is and file another JIRA for the other updates. If you want to update the dependencies then I'll merge that in when you are done too.

@devsprint
Copy link
Copy Markdown
Contributor Author

@revans2 please go ahead.

@revans2
Copy link
Copy Markdown
Contributor

revans2 commented Aug 18, 2014

+1 I'll merge both sets of changes into master.

@asfgit asfgit merged commit 99b914c into apache:master Aug 18, 2014
knusbaum pushed a commit to knusbaum/incubator-storm that referenced this pull request Feb 11, 2015
Fixed Case of test (Dang You Mac File System Semantics!!!!) [BUG 6824000]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants