STORM-453 - migrated to curator 2.5.0 #165
Conversation
|
The changes seem OK to me, but I would like to see a JIRA filed for this and the JIRA number (i.e. STORM-12345) added to the title of the pull request. I really should have gotten to this a long time ago, sorry it has taken so long. |
|
@revans2 Sorry, I haven't seen this update. JIRA ticket is below. |
|
does it make sense to update this PR with newer versions of curator, guava and netty before merge? Btw, current version of cassandra driver mentioned has guava 16.0.1 and netty 3.9.0 in it's list |
|
I tried the change both with and without the updates suggested by @viktortnk Both passed and I am fine either way. @devsprint if you want me to I will merge it in as is and file another JIRA for the other updates. If you want to update the dependencies then I'll merge that in when you are done too. |
|
@revans2 please go ahead. |
|
+1 I'll merge both sets of changes into master. |
Fixed Case of test (Dang You Mac File System Semantics!!!!) [BUG 6824000]
Migrated code to curator 2.5.0 (updated zookeeper version, netty version, guava version). I was not able to find any issue running existing topologies on this code.
This change will allow Cassandra driver integration in bolt/spout without dependencies shadowing or other tricks...