STORM-2323 (1.x) Precondition for Leader Nimbus should check all topology blobs and also corresponding dependencies #1903
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lobs and also corresponding dependencies * change the precondition for leader Nimbus ** it should have all active topology blobs and corresponding dependencies locally * change zookeeper.clj to use Zookeeper.leaderLatchListenerImpl
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
master branch: #1895
The difference between #1895 and this is due to zookeeper.clj. In 1.x branch it has both zookeeper.clj and Zookeeper.java. I don't want to make redundant efforts to get rid of zookeeper.clj, but not also want to modify both of code. So I change zookeeper.clj to refer Zookeeper's leader latch listener implementation.
@harshach
Since you reviewed the PR for master branch, I would ask you to review this as well. Thanks in advance.