STORM-2452: Storm Metric classes are not thread safe#2041
Closed
knusbaum wants to merge 2 commits intoapache:masterfrom
Closed
STORM-2452: Storm Metric classes are not thread safe#2041knusbaum wants to merge 2 commits intoapache:masterfrom
knusbaum wants to merge 2 commits intoapache:masterfrom
Conversation
added 2 commits
April 3, 2017 10:47
Contributor
|
I think thread-unsafety of metrics is by design. They're guaranteed to be called only a thread at the same time, so unless we get or update the value on other than Spout or Bolt's event thread, they should be safe. Updating them is occurred from critical path, and metrics doesn't need to have synchronization overhead with current design. Btw, thread-unsafety on metrics is why I gave up metrics aggregation for worker side. Instead of struggling about metrics more, I'm just waiting for Metrics V2. |
Contributor
|
Please do some benchmark and check performance regression, and please let me know if it doesn't hurt performance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Synchronizing metrics methods