STORM-2660 The Nimbus storm-local directory is relative to the workin…

[HeartSaVioR]

…g directory of the shell executing "storm nimbus"

• Let Nimbus uses same storm-local directory as Supervisor which is known to be valid

[srdo]

Thanks for taking a look at this. The fix looks good, but I think this is an issue elsewhere too. At least this path is making the same mistake

storm/storm-server/src/main/java/org/apache/storm/blobstore/LocalFsBlobStore.java

Line 90 in 85486dd

overrideBase = (String) conf.get(Config.STORM_LOCAL_DIR);

.

Looking at uses of STORM_LOCAL_DIR, I'm wondering if these uses are also suspicious:

• storm/storm-core/src/jvm/org/apache/storm/command/KillWorkers.java

  Line 31 in a4afacd

  conf.put(Config.STORM_LOCAL_DIR, new File((String)conf.get(Config.STORM_LOCAL_DIR)).getCanonicalPath());

  
  *

  storm/storm-server/src/main/java/org/apache/storm/scheduler/utils/ArtifactoryConfigLoader.java

  Line 335 in e1dd247

  String localDirName = (String) conf.get(Config.STORM_LOCAL_DIR);

[HeartSaVioR]

Nice finding @srdo . Addressed other places as well.

[srdo]

I think it could be nice to add to the Config javadoc for the blobstore and storm-local dirs that relative paths will be interpreted as relative to storm.home, unless that's already mentioned somewhere.

[srdo]

I think we can make this a little nicer by having this return absoluteStormLocalDir. There's less risk of us accidentally forgetting to null check the result if this ever gets used elsewhere.

[srdo]

+1, verified that storm nimbus now puts storm-local in the right directory.

[HeartSaVioR]

@srdo Also addressed review comments and squashed commits into one.

[srdo]

+1, thanks :)