STORM-2748: Fix TickTupleTest to actually test something #2334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
revans2
force-pushed
the
STORM-2748
branch
2 times, most recently
from
4701ee3 to
a7304c3
Compare
srdo
approved these changes
Sep 20, 2017
Contributor
srdo
left a comment
srdo
left a comment
There was a problem hiding this comment.
+1 pending tests passing, thanks for fixing this.
| public void prepare(Map<String, Object> conf, TopologyContext topologyContext, OutputCollector outputCollector) {} | ||
| @Override | ||
| public void execute(Tuple tuple) {} | ||
| private static class NoopBlot extends BaseRichBolt { |
| public void cleanup() { } | ||
| @Override | ||
| public void execute(Tuple tuple) { | ||
| LOG.error("GOT {}", tuple); |
Contributor
There was a problem hiding this comment.
Nit: Info or debug might be nicer so a grep for errors in the logs doesn't produce this line.
Contributor
Author
|
@srdo thanks for the review. Trying to get the test to work on the slower VMs is still a work in progress. I'll let you know why I actually have it passing consistently. |
Contributor
Author
|
@srdo I finally have the test passing predictably on travis. I also fixed the issues that you saw. Feel free to take another look. |
srdo
approved these changes
Sep 20, 2017
| } | ||
| tickTupleTimes.clear(); | ||
| cluster.advanceClusterTime(1); | ||
| time += 1000; |
Contributor
There was a problem hiding this comment.
I think this can be put in a loop now, the following lines don't differ anymore.
Contributor
Author
|
@srdo I turned it into a loop like you requested |
Contributor
|
Thanks |
Contributor
|
+1 |
asfgit
pushed a commit
that referenced
this pull request
Sep 21, 2017
… into STORM-2748 STORM-2748: Fix TickTupleTest to actually test something This closes #2334
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.