MINOR: Use booleans instead of strings for 'enable.auto.commit' setting #2427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

asfgit merged 1 commit into apache:master from srdo:use-bool-instead-of-string

Nov 20, 2017

Contributor

srdo commented Nov 19, 2017

Kafka understands booleans in this property just fine, there's no reason to use strings instead.


          MINOR: Use booleans instead of strings for 'enable.auto.commit' setting

Contributor

hmcl commented Nov 20, 2017

+1

asfgit merged commit 7749280 into apache:master

Contributor Author

srdo commented Nov 20, 2017

Thanks, applied to master and 1.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet