Merged
Conversation
…ls to allocate memory. Replace make-maven-plugin with a build shell script.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1.x version of #2462
I didn't think we needed this initially since asprintf isn't used in 1.x, but it looks like the build is failing on 1.x after upgrading to the newest Travis image (e.g. https://travis-ci.org/apache/storm/builds/324620269).
This only contains the replacement of make-maven-plugin. Make-maven-plugin fails to run autoreconf on Travis. The error log is
Googling it leads to travis-ci/travis-cookbooks#964. Sounds like jdk_switcher isn't expecting to be called with a non-bash shell, and it gets called that way when opening sh as a login shell.