[STORM-2932] the naming of topology localityaware configs are confusing#2544
Merged
asfgit merged 1 commit intoapache:masterfrom Feb 14, 2018
Merged
[STORM-2932] the naming of topology localityaware configs are confusing#2544asfgit merged 1 commit intoapache:masterfrom
asfgit merged 1 commit intoapache:masterfrom
Conversation
Contributor
|
The changes look okay to me. I just want to be sure that you are aware that this is a breaking change and the consequences of that. Because this config went into 2.x and has not been released it is probably not a big deal, but if someone has started to use it they would need to change their settings. |
Contributor
Author
|
@revans2 Yes you are right. I assumed that this can be changed since 2.x is not released. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/STORM-2932
The names are confusing. I think we should delete "percent"