STORM-2934 - fix startup ClassNotFoundException when missing RocksDB jar#2546
Merged
asfgit merged 1 commit intoapache:masterfrom Feb 7, 2018
Merged
STORM-2934 - fix startup ClassNotFoundException when missing RocksDB jar#2546asfgit merged 1 commit intoapache:masterfrom
asfgit merged 1 commit intoapache:masterfrom
Conversation
Contributor
|
The dependency rocksdbjni.jar is present in lib/ directory after packaging so there shouldn't be exceptions during nimbus daemon startup. But changing from |
HeartSaVioR
reviewed
Feb 6, 2018
Contributor
HeartSaVioR
left a comment
HeartSaVioR
left a comment
There was a problem hiding this comment.
Looks great. Minor comment.
| @NotNull | ||
| @isImplementationOfClass(implementsClass = MetricStore.class) | ||
| @isString | ||
| //@isImplementationOfClass(implementsClass = MetricStore.class) |
Contributor
There was a problem hiding this comment.
minor: Let's remove this line then. I think below explanation is enough.
Contributor
Author
|
removed comment |
HeartSaVioR
approved these changes
Feb 7, 2018
Contributor
HeartSaVioR
left a comment
HeartSaVioR
left a comment
There was a problem hiding this comment.
+1
Please squash commits into one with having JIRA title & summary as commit title. PR title looks suitable to commit title.
agresch
force-pushed
the
agresch_classnotfound
branch
from
ba01c5c to
30d81a5
Compare
Contributor
Author
|
squashed |
asfgit
pushed a commit
that referenced
this pull request
Feb 7, 2018
into STORM-2934 STORM-2934: fix startup ClassNotFoundException when missing RocksDB jar This closes #2546
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, only Nimbus uses STORM_METRIC_STORE_CLASS.
If the RocksDB jar is missing on Daemons other than Nimbus, they should be able to startup successfully.
If the jar is missing on Nimbus, the metricStore will fail to initialize, and an ERROR will be logged. Nimbus will still be able to run; it just ignores using the metricStore.