STORM-2958 - Use new wait strategy model for Spout as well#2561
Merged
asfgit merged 1 commit intoapache:masterfrom Feb 20, 2018
Merged
STORM-2958 - Use new wait strategy model for Spout as well#2561asfgit merged 1 commit intoapache:masterfrom
asfgit merged 1 commit intoapache:masterfrom
Conversation
HeartSaVioR
approved these changes
Feb 18, 2018
Contributor
HeartSaVioR
left a comment
HeartSaVioR
left a comment
There was a problem hiding this comment.
+1
We may want to explicitly deprecate configurations/interfaces/classes regarding old spout wait strategy in 1.x version line, with mention that they will be removed in 2.0.0.
Contributor
|
@roshannaik |
roshannaik
force-pushed
the
STORM-2958
branch
from
d55a38b to
5199788
Compare
Contributor
Author
|
thanks for catching that. fixed it. |
HeartSaVioR
approved these changes
Feb 20, 2018
Contributor
HeartSaVioR
left a comment
HeartSaVioR
left a comment
There was a problem hiding this comment.
+1 again. Thanks for reflecting review comment quickly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.