fix STORM-2979 (master branch) #2625
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add in WorkerState an internal list of workerHooks and use it to start/stop
HeartSaVioR
reviewed
Apr 8, 2018
Contributor
HeartSaVioR
left a comment
HeartSaVioR
left a comment
There was a problem hiding this comment.
Looks good, left some comments.
| @@ -599,20 +613,16 @@ public WorkerTopologyContext getWorkerTopologyContext() { | |||
| public void runWorkerStartHooks() { | |||
| WorkerTopologyContext workerContext = getWorkerTopologyContext(); | |||
| if (topology.is_set_worker_hooks()) { | |||
Contributor
There was a problem hiding this comment.
if statement unnecessary for now.
| } | ||
|
|
||
| public void runWorkerShutdownHooks() { | ||
| if (topology.is_set_worker_hooks()) { |
Contributor
There was a problem hiding this comment.
if statement unnecessary for now.
| int maxTaskId = getMaxTaskId(componentToSortedTasks); | ||
| this.workerTransfer = new WorkerTransfer(this, topologyConf, maxTaskId); | ||
| this.bpTracker = new BackPressureTracker(workerId, localTaskIds); | ||
| // |
Contributor
There was a problem hiding this comment.
‘//‘ can be removed, and better to extract below to private method as we did above.
Use a private method to deserialize hooks remove unnecessary if statement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add in WorkerState an internal list of deserialized workerHooks and use it to
start/stop