STORM-3109: Fixed incorrect conversion from relative path to absolute path for STORM_LOCAL_DIR#2720
Merged
asfgit merged 1 commit intoapache:masterfrom Jun 17, 2018
Merged
Conversation
… path for STORM_LOCAL_DIR
Contributor
|
Could you explain a bit more why the conversion to absolute path is a problem? I'm having a hard time understanding why kill_workers would break if the STORM_LOCAL_DIR is given as an absolute path. |
Contributor
Author
|
It would break if it’s given as a relative path. File.getCanonicalPath converts it to cwd/STORM_LOCAL_DIR |
Contributor
|
Ah right. Thanks, that makes sense. +1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See issue: https://issues.apache.org/jira/browse/STORM-3109