Skip to content

STORM-3082 Add support to handle absent topics #2755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aniketalhat wants to merge 1 commit into from
Closed

STORM-3082 Add support to handle absent topics #2755

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/NamedTopicFilter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,12 +26,15 @@
import org.apache.kafka.clients.consumer.KafkaConsumer;
import org.apache.kafka.common.PartitionInfo;
import org.apache.kafka.common.TopicPartition;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

/**
* Filter that returns all partitions for the specified topics.
*/
public class NamedTopicFilter implements TopicFilter {

private static final Logger LOG = LoggerFactory.getLogger(NamedTopicFilter.class);
private final Set<String> topics;

/**
Expand All @@ -54,8 +57,13 @@ public NamedTopicFilter(String... topics) {
public List<TopicPartition> getFilteredTopicPartitions(KafkaConsumer<?, ?> consumer) {
List<TopicPartition> allPartitions = new ArrayList<>();
for (String topic : topics) {
for (PartitionInfo partitionInfo: consumer.partitionsFor(topic)) {
allPartitions.add(new TopicPartition(partitionInfo.topic(), partitionInfo.partition()));
List<PartitionInfo> partitionInfoList = consumer.partitionsFor(topic);
if(partitionInfoList != null) {
for (PartitionInfo partitionInfo : partitionInfoList) {
allPartitions.add(new TopicPartition(partitionInfo.topic(), partitionInfo.partition()));
}
} else {
LOG.warn("Topic {} not found, skipping addition of the topic", topic);
}
}
return allPartitions;
Expand Down
15 changes: 15 additions & 0 deletions ...l/storm-kafka-client/src/test/java/org/apache/storm/kafka/spout/NamedTopicFilterTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@

import org.apache.storm.kafka.spout.NamedTopicFilter;

import static org.hamcrest.Matchers.contains;
import static org.hamcrest.Matchers.containsInAnyOrder;
import static org.junit.Assert.assertThat;
import static org.mockito.Mockito.mock;
Expand Down Expand Up @@ -63,6 +64,20 @@ public void testFilter() {

}

@Test
public void testFilterOnAbsentTopic() {
String presentTopic = "present";
String absentTopic = "absent";

NamedTopicFilter filter = new NamedTopicFilter(presentTopic, absentTopic);
when(consumerMock.partitionsFor(presentTopic)).thenReturn(Collections.singletonList(createPartitionInfo(presentTopic, 2)));
when(consumerMock.partitionsFor(absentTopic)).thenReturn(null);

List<TopicPartition> presentPartitions = filter.getFilteredTopicPartitions(consumerMock);
assertThat("Expected filter to pass only topics which are present", presentPartitions,
contains(new TopicPartition(presentTopic, 2)));
}

private PartitionInfo createPartitionInfo(String topic, int partition) {
return new PartitionInfo(topic, partition, null, null, null);
}
Expand Down