[STORM-3271] Docker support: launch storm workers in docker containers#2901
Closed
Ethanlm wants to merge 22 commits intoapache:masterfrom
Closed
[STORM-3271] Docker support: launch storm workers in docker containers#2901Ethanlm wants to merge 22 commits intoapache:masterfrom
Ethanlm wants to merge 22 commits intoapache:masterfrom
Conversation
add user's groups and simply getGroupIdInfo and getUserIdInfo functions
…launcher; fix format and trivial issues.
…tCode if the contaner exits
Contributor
Author
|
We are testing this (with additional related commits) more thoroughly. Will update the pull request after. Additionally, we are working on using |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spent a lot of effort on this.
This patch let storm supervisor launches the worker in a docker container so that user code is isolated from each other and from the host machine. This is a security enhancement.
Detailed explanation of this are available at docs/Docker-support.md in this pr.
I tested it manually (only on
RHEL7, didn't test it on other os systems) and tested with secure cluster setup. Also tested with our own integration test suites with docker support turned off and proved that this pr won't break storm.