STORM-3417: Fix checkstyle violations in sql-core#3035
Merged
srdo merged 1 commit intoapache:masterfrom Jun 27, 2019
krichter722:checkstyle-sql-core
Merged
STORM-3417: Fix checkstyle violations in sql-core#3035srdo merged 1 commit intoapache:masterfrom krichter722:checkstyle-sql-core
srdo merged 1 commit intoapache:masterfrom
krichter722:checkstyle-sql-core
Conversation
srdo
reviewed
Jun 25, 2019
Contributor
srdo
left a comment
srdo
left a comment
There was a problem hiding this comment.
+1 assuming tests pass, left a question but it's not very important.
|
|
||
| /** | ||
| * @return Whether compilation was successful. | ||
| * Compiles source code to byte code. |
Contributor
Author
There was a problem hiding this comment.
We removed the rule to add missing Javadoc on public methods and classes. The rules to validate already present Javadoc were present and remained untouched. I think this makes sense because if Javadoc is present it should be valid. It could also be removed but deciding that slows down the PR workflow in my opinion.
Contributor
Author
|
@srdo This can be merged, right? |
Contributor
|
@krichter722 Yes, soon. We generally wait at least 24 hours before merging, so others get a chance to review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.