STORM-3442 Add owner to supervisor summary#3067
Conversation
Ethanlm
left a comment
Ethanlm
left a comment
There was a problem hiding this comment.
Overall looks good to me. Left some comments.
| /** | ||
| * Get the integer value of this enum value, as defined in the Thrift IDL. | ||
| */ | ||
| @Override |
There was a problem hiding this comment.
In case someone is curious (like me), #3020 modified these generated file (NumErrorsChoice.java and TopologyInitialStatus.java) directly. So the rerun of genthrift.sh in this PR overrides the change. And this is good.
| } | ||
| }, | ||
| { | ||
| data: 'owner', |
There was a problem hiding this comment.
Will this also add "owner" column to the topology summary page? If so, it will be redundant since the topology summary page already has "owner" information
There was a problem hiding this comment.
Correct. This also adds owner to the topology summary page. The duplicate owner can be removed at the cost of adding logic to script.js. It seems a wash to me.
There was a problem hiding this comment.
Removing duplicate owner is simple. Making this change and also removing "owner" tooltip from topology-page-template
| true); //this is the topology page, so we know the user is authorized | ||
| true, //this is the topology page, so we know the user is authorized | ||
| null, | ||
| owner); |
There was a problem hiding this comment.
With this change, the other aggWorkerStats function is no longer used by anyone and can be removed, or change it to
aggWorkerStats(String stormId, String stormName,
Map<Integer, String> task2Component,
Map<List<Integer>, Map<String, Object>> beats,
Map<List<Long>, List<Object>> exec2NodePort,
Map<String, String> nodeHost,
Map<WorkerSlot, WorkerResources> worker2Resources,
boolean includeSys, boolean userAuthorized, String owner)
so by default filterSupervisor is null and then it can be used here.
But this is not very important.
There was a problem hiding this comment.
removing unused overload
Ethanlm
left a comment
Ethanlm
left a comment
There was a problem hiding this comment.
Thanks for the fix. Travis JDK: openjdk11 Java MODULES=Server failed on GPG error. Doesn't seem related. Could you please squash the commits and I can then merge it
2 participants
No description provided.