Skip to content

Conversation

@Ethanlm
Copy link
Contributor

@Ethanlm Ethanlm commented Aug 19, 2019

I think this is not needed. And it can be confusing when it's not updated correctly

@Ethanlm
Copy link
Contributor Author

Ethanlm commented Aug 19, 2019

resolved the conflicts.

@srdo
Copy link
Contributor

srdo commented Aug 19, 2019

Isn't this getting set by the release plugin? If so, it will show up again next time we do a release candidate.

When is the tag tag not being updated correctly?

@srdo
Copy link
Contributor

srdo commented Aug 19, 2019

@Ethanlm
Copy link
Contributor Author

Ethanlm commented Aug 19, 2019

I wanted to remove this from master because master is not a release branch. It doesn't make much sense to have v2.0.0 in master branch especially we are going to move master to 2.2.x-SNAPSHOT

@srdo
Copy link
Contributor

srdo commented Aug 19, 2019

Yes, and that makes sense. But I think the tag will just show up again next time someone makes an RC. It only stays gone if we never do a release from master without branching, and then also never merge the release branches into master.

@Ethanlm
Copy link
Contributor Author

Ethanlm commented Aug 19, 2019

We shouldn't do a minor version release without branching. I don't see why we would merge a release branch to master. What we should do is cherry-pick, right?

@srdo
Copy link
Contributor

srdo commented Aug 19, 2019

Yes, you are right. +1. I don't see the harm of doing this, worst case the tag just shows up again.

@Ethanlm
Copy link
Contributor Author

Ethanlm commented Aug 19, 2019

Thanks for the review

@Ethanlm Ethanlm merged commit 1478fc4 into apache:master Aug 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants