[STORM-557] Created docs directory and added in some svg diagrams.#314
[STORM-557] Created docs directory and added in some svg diagrams.#314asfgit merged 2 commits intoapache:masterfrom
Conversation
|
+1 |
|
Amazing for sharing high-res svg diagrams! Thanks! |
|
I was curious if we wanted to keep a 5MB file in our github repo that everyone must download to get storm? As it stands now the git repo is about 11MB total. This could slow things down for some developers. It might be better to put it in the SVN repo with the web page source http://svn.apache.org/viewvc/storm/ But it would make it less accessible to developers who might want to reuse it. |
|
@revans2 There is another JIRA asking for the current storm.apache.org docs to be moved onto github. |
|
OK so the next question I have is, should we split the one big SVG file up along side rasterized PNG equivalents for use in the docs? |
|
@revans2 sounds like a good idea to provide PNG files. |
|
OK I split them apart, cleaned up one of the SVG images to make it smaller, and added in some PNG versions, along with updating the security document to use one of the PNG images. So now the total new size is 3.6 MB. Hopefully a lot more people will find these useful. |
|
With pull #330 now up, I will wait for it to go in, and then rebase my changes on top of it. |
|
@revans2 can you please upmerge your patch. Thanks. |
|
Enough changed with the docs update, that I opted to just add the images in. If we want to move some of the other markdown documents over we can, but for now I just left them where they were. |
|
+1 |
|
Thank you @revans2. |
No description provided.